jerqi commented on code in PR #9585:
URL: https://github.com/apache/gravitino/pull/9585#discussion_r2667476337
##########
server/src/main/java/org/apache/gravitino/server/web/filter/authorization/AuthorizeExecutorFactory.java:
##########
@@ -23,45 +23,37 @@
import org.apache.gravitino.Entity;
import org.apache.gravitino.NameIdentifier;
import
org.apache.gravitino.server.authorization.annotations.AuthorizationRequest;
-import
org.apache.gravitino.server.authorization.expression.AuthorizationExpressionEvaluator;
public class AuthorizeExecutorFactory {
public static AuthorizationExecutor create(
String expression,
AuthorizationRequest.RequestType requestType,
Map<Entity.EntityType, NameIdentifier> metadataContext,
- AuthorizationExpressionEvaluator authorizationExpressionEvaluator,
Map<String, Object> pathParams,
Optional<String> entityType,
Parameter[] parameters,
- Object[] args) {
+ Object[] args,
+ String secondaryExpression,
+ String secondaryExpressionCondition) {
Review Comment:
This is a proper common ability. We can choose the expression according to
the parameters. If we need more parameters, we can add more parameters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
