mchades commented on code in PR #9560: URL: https://github.com/apache/gravitino/pull/9560#discussion_r2681029578
########## core/src/main/java/org/apache/gravitino/meta/FunctionEntity.java: ########## @@ -0,0 +1,357 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.gravitino.meta; + +import com.google.common.collect.Maps; +import java.util.Arrays; +import java.util.Collections; +import java.util.Map; +import java.util.Objects; +import lombok.ToString; +import org.apache.gravitino.Auditable; +import org.apache.gravitino.Entity; +import org.apache.gravitino.Field; +import org.apache.gravitino.HasIdentifier; +import org.apache.gravitino.Namespace; +import org.apache.gravitino.function.Function; +import org.apache.gravitino.function.FunctionColumn; +import org.apache.gravitino.function.FunctionDefinition; +import org.apache.gravitino.function.FunctionType; +import org.apache.gravitino.rel.types.Type; + +/** + * A class representing a function entity in the metadata store. + * + * <p>This entity stores both the function metadata and its version information together, avoiding + * the need for separate FunctionEntity and FunctionVersionEntity. When retrieving, if version is + * set to the special value {@link #LATEST_VERSION}, the store should return the latest version. + */ +@ToString +public class FunctionEntity implements Entity, Auditable, HasIdentifier, Function { + + /** Special version value indicating the latest version should be retrieved. */ + public static final int LATEST_VERSION = -1; + + public static final Field ID = + Field.required("id", Long.class, "The unique id of the function entity."); + public static final Field NAME = + Field.required("name", String.class, "The name of the function entity."); + public static final Field COMMENT = + Field.optional("comment", String.class, "The comment or description of the function entity."); + public static final Field FUNCTION_TYPE = + Field.required("function_type", FunctionType.class, "The type of the function."); + public static final Field DETERMINISTIC = + Field.required("deterministic", Boolean.class, "Whether the function is deterministic."); + public static final Field RETURN_TYPE = + Field.optional( + "return_type", Type.class, "The return type for scalar or aggregate functions."); + public static final Field RETURN_COLUMNS = + Field.optional( + "return_columns", + FunctionColumn[].class, + "The output columns for table-valued functions."); + public static final Field DEFINITIONS = + Field.required("definitions", FunctionDefinition[].class, "The definitions of the function."); + public static final Field VERSION = + Field.required("version", Integer.class, "The version of the function entity."); Review Comment: The changes have already been implemented as discussed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
