danhuawang commented on issue #9694: URL: https://github.com/apache/gravitino/issues/9694#issuecomment-3742646910
> The code indeed validates the new comment for `UpdateTableColumnCommentRequest`, ensuring it is neither empty nor an empty string. > > [gravitino/common/src/main/java/org/apache/gravitino/dto/requests/TableUpdateRequest.java](https://github.com/apache/gravitino/blob/ba3953fb16c5bb4e6988e02d9f3b1695bc4593be/common/src/main/java/org/apache/gravitino/dto/requests/TableUpdateRequest.java#L621-L628) > > Lines 621 to 628 in [ba3953f](/apache/gravitino/commit/ba3953fb16c5bb4e6988e02d9f3b1695bc4593be) > > Preconditions.checkArgument( > fieldName != null > && fieldName.length > 0 > && Arrays.stream(fieldName).allMatch(StringUtils::isNotBlank), > "\"fieldName\" field is required and cannot be empty"); > Preconditions.checkArgument( > StringUtils.isNotBlank(newComment), > "\"newComment\" field is required and cannot be empty"); > > I can clear a column's comment through UI. > > This should not succeed. Could you paste the actual request sent by the UI? Text by mistake. I can't clear a column's comment through UI. <img width="1112" height="503" alt="Image" src="https://github.com/user-attachments/assets/83faffa5-c572-45b9-ac9c-82134c72f4c9"; /> <img width="1033" height="468" alt="Image" src="https://github.com/user-attachments/assets/b205d9e9-3d57-48aa-8f12-459a74be9623"; /> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
