bharos commented on code in PR #10020:
URL: https://github.com/apache/gravitino/pull/10020#discussion_r2838285689
##########
iceberg/iceberg-rest-server/src/main/java/org/apache/gravitino/server/web/filter/IcebergMetadataAuthorizationMethodInterceptor.java:
##########
@@ -81,10 +81,16 @@ protected Map<Entity.EntityType, NameIdentifier>
extractNameIdentifierFromParame
metalakeName, catalog, schema,
RESTUtil.decodeString(value)));
Review Comment:
I think it is not required, because the load-table auth expression doesn't
have view related checks
The LoadTableAuthzHandler only does
```
if (wrapperManager.getCatalogWrapper(catalog).viewExists(tableIdentifier)) {
```
which doesn't need adding VIEW entity
Also, Spark always probes /views/name for every relation, including pure
tables. But reverse is not true. It doesn't simply check /tables/name endpoint
for views, so this not needed for now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
