Copilot commented on code in PR #10031:
URL: https://github.com/apache/gravitino/pull/10031#discussion_r2850661264
##########
integration-test-common/src/test/java/org/apache/gravitino/integration/test/container/ContainerSuite.java:
##########
@@ -454,9 +454,9 @@ public void startOceanBaseContainer() {
"OB_DATAFILE_SIZE",
"1G",
"OB_LOG_DISK_SIZE",
- "2G",
+ "8G",
"OB_MEMORY_LIMIT",
- "4G"))
+ "6G"))
Review Comment:
`startOceanBaseContainer()` doesn't call `initIfNecessary()` before using
`network` / Testcontainers, unlike the other `start*Container` methods in this
class. If OceanBase is the first container started, Docker availability won't
be checked and the optional CI network won't be created, which can lead to
failures or running on an unexpected network. Call `initIfNecessary()` before
building/starting the OceanBase container (e.g., right after
`ITUtils.cleanDisk()`).
##########
.github/workflows/build.yml:
##########
@@ -15,7 +15,7 @@ concurrency:
# A workflow run is made up of one or more jobs that can run sequentially or
in parallel
jobs:
changes:
- runs-on: ubuntu-22.04
+ runs-on: ubuntu-latest
Review Comment:
The PR description/metadata references fixing #9990 (Docker/Testcontainers
failing due to an API version mismatch and needing a Testcontainers upgrade),
but this change set only updates the runner image for the paths-filter job and
adjusts/enables OceanBase tests. If this PR is meant to close #9990, it likely
also needs the Testcontainers/docker-java version bump (or alternatively
remove/adjust the 'Fix: #9990' linkage so it doesn't incorrectly close the
issue).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
