zhoukangcn commented on code in PR #10046:
URL: https://github.com/apache/gravitino/pull/10046#discussion_r2876310322
##########
integration-test-common/src/test/java/org/apache/gravitino/integration/test/container/DorisContainer.java:
##########
@@ -63,78 +84,130 @@ protected DorisContainer(
Map<String, String> envVars,
Optional<Network> network) {
super(image, hostName, ports, extraHosts, filesToMount, envVars, network);
- }
Review Comment:
I'd suggest not making this change for now. The current implementation works
fine and removing the BaseContainer extension would be a bigger refactor that's
out of scope for this PR. We can address it separately later if needed.
@yuqi1129 What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
