justinmclean commented on PR #10170: URL: https://github.com/apache/gravitino/pull/10170#issuecomment-3994641504
Thanks for the fix. The change to make drop-log timestamp state atomic looks correct and addresses the concurrency risk in AsyncQueueListener. The new concurrency test is a good smoke test for “no exception under load,” but it may not test this exact issue. I have a few small suggestions to improve the test: - latch.await(30, TimeUnit.SECONDS); currently ignores the boolean return value. Could we assert it is true so that the test clearly fails on timeout? - consider one extra assertion tied to throttle behavior to better check the specific logging-rate logic changed In the code you could: - capture Instant now = Instant.now() once in logDropEventsIfNecessary() and reuse it for both comparison and update. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
