Copilot commented on code in PR #10179:
URL: https://github.com/apache/gravitino/pull/10179#discussion_r2881596524
##########
docs/how-to-build.md:
##########
@@ -47,13 +47,7 @@ license: "This software is licensed under the Apache License
version 2."
The `./gradlew build` command builds all the Gravitino components, including
the Gravitino server, Java and Python clients, Trino and Spark connectors, and
more.
- For the Python client, the `./gradlew build` command builds the Python
client with Python 3.9 by default. If you want to use Python 3.10, 3.11, or
3.12 to build, please modify the property `pythonVersion` to 3.10, 3.11, or
3.12 in the `gradle.properties` file, or specify the version with `-P` like:
-
- ```shell
- ./gradlew build -PpythonVersion=3.9
- ```
-
- Or:
+ For the Python client, the `./gradlew build` command builds the Python
client with Python 3.12 by default. If you want to use Python 3.10, 3.11, or
3.13 to build, please modify the property `pythonVersion` to 3.10, 3.11, or
3.13 in the `gradle.properties` file, or specify the version with `-P` like:
Review Comment:
There is an inconsistency in the supported Python versions across this PR:
1. Line 16 (Prerequisites section) lists "Python 3.10, 3.11, or 3.12" —
Python 3.13 is missing here.
2. Line 50 lists "Python 3.10, 3.11, or 3.13" — Python 3.12 appears to be
incorrectly replaced with 3.13, since 3.12 is the default and is clearly tested
(lines 64-66 show a `3.12` example command, and the CI workflow tests 3.12 but
not 3.13).
The shell command examples on lines 52–66 still show only 3.10, 3.11, and
3.12 (no 3.13 example), which is inconsistent with the text on line 50 that
says 3.13 is an alternative.
Additionally, `clients/client-python/setup.py` classifiers only enumerate
Python 3.10, 3.11, and 3.12 (no 3.13), and the CI workflow
`.github/workflows/python-integration-test.yml` only tests against 3.10, 3.11,
and 3.12 — neither source confirms that Python 3.13 is officially supported.
The text on line 50 should likely read "Python 3.10, 3.11, 3.12, or 3.13"
(i.e., keep 3.12 and add 3.13 if it is truly supported), or drop the 3.13
reference entirely if it has not been verified. The Prerequisites on line 16
should also be updated to be consistent with whatever the final list is.
```suggestion
For the Python client, the `./gradlew build` command builds the Python
client with Python 3.12 by default. If you want to use Python 3.10, 3.11, or
3.12 to build, please modify the property `pythonVersion` to 3.10, 3.11, or
3.12 in the `gradle.properties` file, or specify the version with `-P` like:
```
##########
docs/how-to-build.md:
##########
@@ -13,7 +13,7 @@ license: "This software is licensed under the Apache License
version 2."
+ Linux or macOS operating system
+ Git
+ A Java Development Kit, version 17, installed in your environment to launch
Gradle
-+ Python 3.9, 3.10, 3.11, or 3.12 to build the Gravitino Python client
++ Python 3.10, 3.11, or 3.12 to build the Gravitino Python client
Review Comment:
The Prerequisites section now lists "Python 3.10, 3.11, or 3.12" (missing
Python 3.13), while the build instructions on line 50 say "Python 3.10, 3.11,
or 3.13". These two lists are inconsistent and need to match. If Python 3.13 is
intended to be supported, it should be added here as well. If it is not
officially supported/tested, it should be removed from line 50.
```suggestion
+ Python 3.10, 3.11, 3.12, or 3.13 to build the Gravitino Python client
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
