Copilot commented on code in PR #10106:
URL: https://github.com/apache/gravitino/pull/10106#discussion_r2883460653
##########
maintenance/jobs/build.gradle.kts:
##########
@@ -25,6 +25,11 @@ plugins {
alias(libs.plugins.shadow)
}
+java {
+ sourceCompatibility = JavaVersion.VERSION_17
+ targetCompatibility = JavaVersion.VERSION_17
+}
+
Review Comment:
In the root build, `:maintenance:jobs` is explicitly treated as
JDK8-compatible (toolchain 17 but `sourceCompatibility/targetCompatibility` set
to 1.8). Overriding this subproject to Java 17 here will produce Java 17
bytecode and breaks the repo’s JDK8-compatibility contract for
`:maintenance:jobs`. Please remove this override (or, if the jobs artifact
truly must require Java 17, update the root `compatibleWithJDK8` logic
accordingly and ensure downstream packaging/runtime expectations are adjusted).
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
