roryqi commented on code in PR #10523:
URL: https://github.com/apache/gravitino/pull/10523#discussion_r2979294912
##########
server/src/main/java/org/apache/gravitino/server/web/ConfigServlet.java:
##########
@@ -49,7 +49,7 @@ public class ConfigServlet extends HttpServlet {
OAuthConfig.SCOPE);
private static final ImmutableSet<ConfigEntry<?>> basicConfigEntries =
- ImmutableSet.of(Configs.AUTHENTICATORS, Configs.ENABLE_AUTHORIZATION);
+ ImmutableSet.of(Configs.AUTHENTICATORS, Configs.ENABLE_AUTHORIZATION,
Configs.SERVICE_ADMINS);
Review Comment:
If we don't set `serviceAdmin`, it will throw the exception because of the
method `checkValue`.
```
public static final ConfigEntry<List<String>> SERVICE_ADMINS =
new ConfigBuilder("gravitino.authorization.serviceAdmins")
.doc("The admins of Gravitino service")
.version(ConfigConstants.VERSION_0_5_0)
.stringConf()
.toSequence()
.checkValue(
valueList ->
valueList != null &&
valueList.stream().allMatch(StringUtils::isNotBlank),
ConfigConstants.NOT_BLANK_ERROR_MSG)
.create();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
