laserninja commented on PR #10500: URL: https://github.com/apache/gravitino/pull/10500#issuecomment-4159866710
1. **Created `GravitinoTableExecuteHandle`** — a new wrapper class following the same pattern as `GravitinoInsertTableHandle`, using `HandleWrapper` for JSON serialization/deserialization across plugin classloaders. 2. **Wrapping in `getTableHandleForExecute()`** — all 6 version-specific metadata classes now wrap the internal connector's handle via `.map(GravitinoTableExecuteHandle::new)`. 3. **Unwrapping before delegation** — `executeTableExecute()`, `beginTableExecute()`, `finishTableExecute()`, `getLayoutForTableExecute()`, and `createPageSink()` all call `GravitinoHandle.unWrap()` on the execute handle before passing to the internal connector. 4. **Fixed test comment** — changed "far future timestamp keeps all" to "expire all snapshots older than now" to match the `retention_threshold => '0s'` behavior. 5. **Updated unit tests** — tests now verify that handles are wrapped in `GravitinoTableExecuteHandle` on return and properly unwrapped before delegation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
