justinmclean opened a new issue, #10657:
URL: https://github.com/apache/gravitino/issues/10657
### What would you like to be improved?
GroupRoleRelMapper.softDeleteGroupRoleRelByMetalakeId(Long metalakeId) is
used in the metalake deletion path, but unlike the neighboring soft-delete
mappers it does not declare @Param("metalakeId") on the mapper method.
The SQL providers for this path reference #{metalakeId}:
GroupRoleRelBaseSQLProvider.java
GroupRoleRelPostgreSQLProvider.java
The mapper is invoked from the metalake delete flow in
MetalakeMetaService.java.
Relying on the runtime-retained Java parameter name is fragile. This can
cause MyBatis named-parameter binding failures during metalake deletion.
### How should we improve?
Add @Param("metalakeId") to:
GroupRoleRelMapper.softDeleteGroupRoleRelByMetalakeId
Optionally, also the corresponding factory/provider method parameters for
consistency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
