bharos commented on code in PR #10652:
URL: https://github.com/apache/gravitino/pull/10652#discussion_r3029379170
##########
iceberg/iceberg-rest-server/src/main/java/org/apache/gravitino/iceberg/service/rest/IcebergConfigOperations.java:
##########
@@ -98,13 +99,19 @@ public IcebergConfigOperations(IcebergCatalogWrapperManager
catalogWrapperManage
@Produces(MediaType.APPLICATION_JSON)
@Timed(name = "config." + MetricNames.HTTP_PROCESS_DURATION, absolute = true)
@ResponseMetered(name = "config", absolute = true)
- public Response getConfig(@DefaultValue("") @QueryParam("warehouse") String
warehouse) {
- String catalogName = getCatalogName(warehouse);
+ public Response getConfig(
+ @PathParam("prefix") String prefix,
+ @DefaultValue("") @QueryParam("warehouse") String warehouse) {
+ String prefixCatalogName = IcebergRESTUtils.getCatalogName(prefix);
+ String catalogName =
+ StringUtils.isNotBlank(prefix) ? prefixCatalogName :
getCatalogName(warehouse);
Review Comment:
Thanks @roryqi for checking this, I too see that the config doesn't have
prefix in the spec as well:
https://github.com/apache/iceberg/blob/1a2a8a5ecc701629183405ca842f2d1eb23505ee/open-api/rest-catalog-open-api.yaml#L65
So I guess this change is not required, just need to remove prefix parameter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
