mchades commented on code in PR #10691:
URL: https://github.com/apache/gravitino/pull/10691#discussion_r3043946700
##########
docs/gravitino-server-config.md:
##########
@@ -174,25 +174,26 @@ Gravitino triggers a pre-event before the operation, a
post-event after the comp
| Operation type | Post-event
| Since Version |
|-----------------------------------------|------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|------------------|
-| table operation | `CreateTableEvent`,
`AlterTableEvent`, `DropTableEvent`, `LoadTableEvent`, `ListTableEvent`,
`PurgeTableFailureEvent`, `CreateTableFailureEvent`, `AlterTableFailureEvent`,
`DropTableFailureEvent`, `LoadTableFailureEvent`, `ListTableFailureEvent`,
`PurgeTableFailureEvent`
|
0.5.0 |
-| fileset operation | `CreateFileSetEvent`,
`AlterFileSetEvent`, `DropFileSetEvent`, `LoadFileSetEvent`,
`ListFileSetEvent`, `CreateFileSetFailureEvent`, `AlterFileSetFailureEvent`,
`DropFileSetFailureEvent`, `LoadFileSetFailureEvent`,
`ListFileSetFailureEvent`, `ListFilesFailureEvent`
| 0.5.0 |
+| table operation | `CreateTableEvent`,
`AlterTableEvent`, `DropTableEvent`, `LoadTableEvent`, `ListTableEvent`,
`PurgeTableEvent`, `CreateTableFailureEvent`, `AlterTableFailureEvent`,
`DropTableFailureEvent`, `LoadTableFailureEvent`, `ListTableFailureEvent`,
`PurgeTableFailureEvent`
| 0.5.0 |
+| fileset operation | `CreateFileSetEvent`,
`AlterFileSetEvent`, `DropFileSetEvent`, `LoadFileSetEvent`,
`ListFileSetEvent`, `GetFileLocationEvent`, `ListFilesEvent`,
`CreateFileSetFailureEvent`, `AlterFileSetFailureEvent`,
`DropFileSetFailureEvent`, `LoadFileSetFailureEvent`,
`ListFileSetFailureEvent`, `GetFileLocationFailureEvent`,
`ListFilesFailureEvent`
| 0.5.0 |
Review Comment:
I think this row still uses the old `FileSet` spellings for the post-event
classes. The actual listener event classes under
`core/src/main/java/org/apache/gravitino/listener/api/event/` are
`CreateFilesetEvent`, `AlterFilesetEvent`, `DropFilesetEvent`,
`LoadFilesetEvent`, `ListFilesetEvent`, and the corresponding `*FailureEvent`
variants. Could we update this row to use `Fileset` consistently? The pre-event
row below already does.
##########
docs/gravitino-server-config.md:
##########
@@ -204,20 +205,20 @@ Gravitino triggers a pre-event before the operation, a
post-event after the comp
| Iceberg REST server view operation | `IcebergCreateViewPreEvent`,
`IcebergReplaceViewPreEvent`, `IcebergDropViewPreEvent`,
`IcebergLoadViewPreEvent`, `IcebergListViewPreEvent`,
`IcebergViewExistsPreEvent`, `IcebergRenameViewPreEvent`
| 0.8.0-incubating |
| Gravitino server table operation | `CreateTablePreEvent`,
`AlterTablePreEvent`, `DropTablePreEvent`, `PurgeTablePreEvent`,
`LoadTablePreEvent`, `ListTablePreEvent`
|
0.8.0-incubating |
| Gravitino server schema operation | `CreateSchemaPreEvent`,
`AlterSchemaPreEvent`, `DropSchemaPreEvent`, `LoadSchemaPreEvent`,
`ListSchemaPreEvent`
|
0.8.0-incubating |
-| Gravitino server catalog operation | `CreateCatalogPreEvent`,
`AlterCatalogPreEvent`, `DropCatalogPreEvent`, `LoadCatalogPreEvent`,
`ListCatalogPreEvent`
| 0.8.0-incubating |
-| Gravitino server metalake operation | `CreateMetalakePreEvent`,
`AlterMetalakePreEvent`,`DropMetalakePreEvent`,`LoadMetalakePreEvent`,`ListMetalakePreEvent`
| 0.8.0-incubating |
+| Gravitino server catalog operation | `CreateCatalogPreEvent`,
`AlterCatalogPreEvent`, `DropCatalogPreEvent`, `LoadCatalogPreEvent`,
`ListCatalogPreEvent`, `EnableCatalogPreEvent`, `DisableCatalogPreEvent`
| 0.8.0-incubating
|
+| Gravitino server metalake operation | `CreateMetalakePreEvent`,
`AlterMetalakePreEvent`, `DropMetalakePreEvent`, `LoadMetalakePreEvent`,
`ListMetalakePreEvent`, `EnableMetalakePreEvent`, `DisableMetalakePreEvent`
| 0.8.0-incubating |
| Gravitino server partition operation | `AddPartitionPreEvent`,
`DropPartitionPreEvent`, `GetPartitionPreEvent`,
`PurgePartitionPreEvent`,`ListPartitionPreEvent`,`ListPartitionNamesPreEvent`
| 0.8.0-incubating |
| Gravitino server fileset operation | `CreateFilesetPreEvent`,
`AlterFilesetPreEvent`, `DropFilesetPreEvent`,
`LoadFilesetPreEvent`,`ListFilesetPreEvent`,`GetFileLocationPreEvent`,
`ListFilesPreEvent`
| 0.8.0-incubating |
-| Gravitino server model operation | `DeleteModelPreEvent`,
`DeleteModelVersionPreEvent`,
`RegisterAndLinkModelPreEvent`,`GetModelPreEvent`,
`GetModelVersionPreEvent`,`LinkModelVersionPreEvent`,`ListModelPreEvent`,`RegisterModelPreEvent`,
`AlterModelPreEvent`, `AlterModelVersionPreEvent`, `AlterModelVersionPreEvent`
| 0.9.0-incubating |
+| Gravitino server model operation | `DeleteModelPreEvent`,
`DeleteModelVersionPreEvent`, `RegisterAndLinkModelPreEvent`,
`GetModelPreEvent`, `GetModelVersionPreEvent`, `GetModelVersionUriPreEvent`,
`LinkModelVersionPreEvent`, `ListModelPreEvent`,
`ListModelVersionInfosPreEvent`, `RegisterModelPreEvent`, `AlterModelPreEvent`,
`AlterModelVersionPreEvent` | 0.9.0-incubating |
Review Comment:
Looks like `ListModelVersionPreEvent` is still missing from this row. We add
`ListModelVersionInfosPreEvent` here, but
`core/src/main/java/org/apache/gravitino/listener/api/event/ListModelVersionPreEvent.java`
also exists on `main`, so the model pre-event list is still incomplete without
it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
