mchades opened a new pull request, #10701: URL: https://github.com/apache/gravitino/pull/10701
### What changes were proposed in this pull request? This PR hardens the retention cleanup assertions in: - `TestFunctionMetaService.testDeleteFunctionVersionsByRetentionCount()` - `TestFilesetMetaService.testDeleteFilesetVersionsByRetentionCount()` Instead of only checking aggregate active/deleted counts, the tests now: - verify that all expected versions are active before retention cleanup - verify exactly which versions are soft deleted after cleanup - verify that the latest retained versions remain active This is a test-only change. No product logic is modified. ### Why are the changes needed? The previous assertions were brittle and low-signal for intermittent CI failures. When a failure happened, the tests only reported that the number of active or deleted versions did not match the expected count, but they did not reveal which version state was wrong or whether the inconsistency was already present before retention cleanup started. By asserting concrete version states, future failures become easier to diagnose and the tests more accurately capture the intended behavior. Fix: #10700 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? - `./gradlew --no-daemon :core:spotlessApply :core:test --tests org.apache.gravitino.storage.relational.service.TestFunctionMetaService.testDeleteFunctionVersionsByRetentionCount --tests org.apache.gravitino.storage.relational.service.TestFilesetMetaService.testDeleteFilesetVersionsByRetentionCount -PskipITs -PskipDockerTests=false` - Repeated the same targeted test command 3 times locally in embedded mode -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
