Copilot commented on code in PR #10969:
URL: https://github.com/apache/gravitino/pull/10969#discussion_r3208470748
##########
scripts/h2/upgrade-1.2.0-to-1.3.0-h2.sql:
##########
@@ -64,3 +64,40 @@ CREATE TABLE IF NOT EXISTS `view_version_info` (
KEY `idx_vvcid` (`catalog_id`),
KEY `idx_vvsid` (`schema_id`)
) ENGINE=InnoDB;
+
+CREATE TABLE IF NOT EXISTS `idp_user_meta` (
+ `user_id` BIGINT(20) UNSIGNED NOT NULL COMMENT 'idp user id',
+ `user_name` VARCHAR(128) NOT NULL COMMENT 'idp username',
+ `password_hash` VARCHAR(1024) NOT NULL COMMENT 'idp user password hash',
+ `audit_info` CLOB NOT NULL COMMENT 'idp user audit info',
Review Comment:
The PR description cites running `TestSQLScripts`, but that test currently
does not execute `upgrade-*-to-*.sql` scripts (it only asserts a schema script
exists for the `from` version, then executes only schema/metrics scripts). This
means the new 1.2.0→1.3.0 upgrade DDL here is not validated by CI. Consider
extending `TestSQLScripts` (or adding a dedicated migration test) to apply the
`from` schema and then execute the upgrade scripts for each backend.
##########
scripts/postgresql/upgrade-1.2.0-to-1.3.0-postgresql.sql:
##########
@@ -91,3 +91,66 @@ COMMENT ON COLUMN view_version_info.default_schema IS
'default schema for view S
COMMENT ON COLUMN view_version_info.representations IS 'view representations
(JSON array)';
COMMENT ON COLUMN view_version_info.audit_info IS 'view version audit info';
COMMENT ON COLUMN view_version_info.deleted_at IS 'view version deleted at';
+
+CREATE TABLE IF NOT EXISTS idp_user_meta (
+ user_id BIGINT NOT NULL,
+ user_name VARCHAR(128) NOT NULL,
+ password_hash VARCHAR(1024) NOT NULL,
+ audit_info TEXT NOT NULL,
Review Comment:
The PR description cites running `TestSQLScripts`, but that test currently
does not execute `upgrade-*-to-*.sql` scripts (it only asserts a schema script
exists for the `from` version, then executes only schema/metrics scripts). This
means the new 1.2.0→1.3.0 upgrade DDL here is not validated by CI. Consider
extending `TestSQLScripts` (or adding a dedicated migration test) to apply the
`from` schema and then execute the upgrade scripts for each backend.
##########
scripts/mysql/upgrade-1.2.0-to-1.3.0-mysql.sql:
##########
@@ -78,3 +78,40 @@ CREATE TABLE IF NOT EXISTS `view_version_info` (
KEY `idx_vvcid` (`catalog_id`),
KEY `idx_vvsid` (`schema_id`)
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_bin COMMENT 'view
version info';
+
+CREATE TABLE IF NOT EXISTS `idp_user_meta` (
+ `user_id` BIGINT(20) UNSIGNED NOT NULL COMMENT 'idp user id',
+ `user_name` VARCHAR(128) NOT NULL COMMENT 'idp username',
+ `password_hash` VARCHAR(1024) NOT NULL COMMENT 'idp user password hash',
+ `audit_info` MEDIUMTEXT NOT NULL COMMENT 'idp user audit info',
Review Comment:
The PR description cites running `TestSQLScripts`, but that test currently
does not execute `upgrade-*-to-*.sql` scripts (it only asserts a schema script
exists for the `from` version, then executes only schema/metrics scripts). This
means the new 1.2.0→1.3.0 upgrade DDL here is not validated by CI. Consider
extending `TestSQLScripts` (or adding a dedicated migration test) to apply the
`from` schema and then execute the upgrade scripts for each backend.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
