mchades commented on code in PR #10992:
URL: https://github.com/apache/gravitino/pull/10992#discussion_r3223322591
##########
catalogs/catalog-lakehouse-iceberg/src/main/java/org/apache/gravitino/catalog/lakehouse/iceberg/IcebergCatalogOperations.java:
##########
@@ -658,6 +736,13 @@ private static Distribution getIcebergDefaultDistribution(
return Distributions.NONE;
}
+ private IcebergViewCatalogOperations viewCatalogOperations() {
+ if (icebergViewCatalogOperations == null) {
+ icebergViewCatalogOperations = new
IcebergViewCatalogOperations(icebergCatalogWrapper);
+ }
+ return icebergViewCatalogOperations;
+ }
Review Comment:
Fixed in 9da1940fa. The null-check lazy-init in `viewCatalogOperations()`
was dead code — the field is already eagerly initialized in `initialize()`.
Removed the null-check entirely; the method now simply returns the field.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
