atovk commented on PR #11042:
URL: https://github.com/apache/gravitino/pull/11042#issuecomment-4430468602
> Should we fix this issue in the Iceberg side instead of Gravitino side?
I think we should keep the fix on the Gravitino side for this PR, and I
will also follow up in Iceberg via apache/iceberg#16299
(https://github.com/apache/iceberg/issues/16299).
Gravitino already knows the table metadata location through
SupportsMetadataLocation, so it can short-circuit before entering Iceberg’s
metadata read path. That gives us a fast and consistent failure for loadTable
and tableExists, instead of waiting for Iceberg’s metadata read retry loop
when the metadata file is missing.
The Iceberg issue is still valid and complementary: some FileIO read
paths, such as Aliyun OSS and Dell ECS, should translate missing-object read
failures into Iceberg NotFoundException consistently. I’ll address that
upstream in Iceberg, but it depends on an Iceberg change and a later
dependency upgrade in Gravitino.
So for this PR, I would keep the storage-neutral Gravitino fix, and use
apache/iceberg#16299 as the upstream follow-up for the underlying
FileIO/read-path behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
