laserninja commented on code in PR #10757:
URL: https://github.com/apache/gravitino/pull/10757#discussion_r3245650586


##########
docs/trino-connector/catalog-postgresql.md:
##########
@@ -27,8 +27,11 @@ Otherwise, schema names, table names or column names 
containing uppercase letter
 ## Create table
 
 At present, the Apache Gravitino Trino connector only supports basic 
PostgreSQL table creation statements, which involve fields, null allowances, 
and comments. However, it does not support advanced features like primary keys, 
indexes, default values, and auto-increment.
+The Gravitino Trino connector supports `CREATE TABLE AS SELECT`.
 
-The Gravitino Trino connector does not support `CREATE TABLE AS SELECT`.
+:::note
+`CREATE OR REPLACE TABLE AS SELECT` is not supported. Use `DROP TABLE` 
followed by `CREATE TABLE AS SELECT` as an alternative.
+:::

Review Comment:
   I've updated catalog-hive.md to reflect that CTAS is now supported (with the 
same note about CREATE OR REPLACE TABLE AS SELECT not being supported), and 
added a Hive CTAS integration test (00018_ctas.sql/txt) with the same three 
scenarios used for MySQL and PostgreSQL.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to