yuqi1129 commented on PR #11070:
URL: https://github.com/apache/gravitino/pull/11070#issuecomment-4456711982

   > Updated in the latest commit:
   > 
   > * `handleLanceTableChange` now resolves `lance.storage.*` from catalog + 
table properties and passes the merged storage map into `openDataset`, so 
alter/index/drop operations work without Spark-side storage config.
   > * Added a focused unit test in `TestLanceTableOperations` to cover the 
catalog-default storage path.
   > 
   > I am leaving the secret/public property split for a follow-up because that 
is a broader catalog-property cleanup across the codebase, not specific to this 
Lance fix. WDYT?@yuqi
   
   It looks good to me.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to