yuqi1129 commented on code in PR #11060: URL: https://github.com/apache/gravitino/pull/11060#discussion_r3256249108
########## docs/lance-rest-integration.md: ########## @@ -22,12 +22,17 @@ The following table outlines the tested compatibility between Gravitino versions | Gravitino Version (Lance REST) | Supported lance-spark Versions | Supported lance-ray Versions | |--------------------------------|--------------------------------|------------------------------| -| 1.1.1 - 1.2.1 | 0.0.10 - 0.0.15 | 0.0.6 - 0.0.8 | -| 1.3.0 | 0.1.0 - 0.2.0 | 0.0.6 - 0.2.0 | +| 1.1.1 - 1.2.1 | 0.0.10 - 0.0.15 | 0.0.6 - 0.0.8 | +| 1.3.0 | 0.1.0 - 0.4.0 | 0.3.0 - 0.4.2 | Review Comment: Confirmed unsupported. Spun up Gravitino 1.3.0 (post-upgrade) and ran the lance-ray IT against each version with `lance-namespace==0.7.5` pinned. The PyPI install actually succeeds for all of these; the failures show up at runtime: - **0.1.0**: `TypeError: write_lance() got an unexpected keyword argument 'namespace_impl'`. 0.1.0's `write_lance(...)` takes `namespace: LanceNamespace` directly; the IT (and 0.2.0+) use the new `namespace_impl: str` + `namespace_properties: dict` form, so the call doesn't even reach the server. - **0.2.0**: `ImportError: cannot import name 'LanceNamespaceStorageOptionsProvider' from 'lance'`. The IT call signature matches, but `lance_ray.utils.create_storage_options_provider` does `from lance import LanceNamespaceStorageOptionsProvider`, and that symbol no longer exists in the `pylance` 6.0.0 wheel that `lance-namespace==0.7.5` pulls in. - **0.3.0** (positive control): PASS — 1000-row Ray dataset round-trips through write_lance / read_lance. I updated `docs/lance-rest-integration.md` in #11119 to replace the inaccurate "pip resolves them with an older lance-namespace" line with these two concrete failure modes, so future readers know exactly what breaks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
