yuqi1129 commented on code in PR #11087:
URL: https://github.com/apache/gravitino/pull/11087#discussion_r3264818505
##########
catalogs/catalog-glue/src/main/java/org/apache/gravitino/catalog/glue/GlueTablePropertiesMetadata.java:
##########
@@ -40,25 +48,55 @@
*/
public class GlueTablePropertiesMetadata extends BasePropertiesMetadata {
- private static final Map<String, PropertyEntry<?>> PROPERTIES_METADATA =
- ImmutableMap.<String, PropertyEntry<?>>builder()
- .put(
- TABLE_FORMAT,
- stringOptionalPropertyEntry(
- TABLE_FORMAT,
- "Table format stored in Table.parameters(). Common values:
ICEBERG, HIVE.",
- false /* immutable */,
- null /* defaultValue */,
- false /* hidden */))
- .put(
- METADATA_LOCATION,
- stringOptionalPropertyEntry(
- METADATA_LOCATION,
- "Iceberg metadata file location stored in
Table.parameters().",
- false /* immutable */,
- null /* defaultValue */,
- false /* hidden */))
- .build();
+ private static final Map<String, PropertyEntry<?>> PROPERTIES_METADATA;
+
+ static {
+ List<PropertyEntry<?>> propertyEntries =
+ ImmutableList.of(
+ stringOptionalPropertyEntry(
+ TABLE_FORMAT,
+ "Table format stored in Table.parameters(). Common values:
ICEBERG, HIVE.",
+ false,
+ null,
+ false),
+ stringOptionalPropertyEntry(
+ METADATA_LOCATION,
+ "Iceberg metadata file location stored in Table.parameters().",
+ false,
+ null,
+ false),
+ stringImmutablePropertyEntry(
+ FORMAT,
+ "The table file format (parquet, orc, textfile, etc.). When
set, "
+ + "input-format, output-format, and serde-lib are derived
from this.",
+ false,
+ null,
+ false,
+ false),
+ stringImmutablePropertyEntry(
+ INPUT_FORMAT,
Review Comment:
INPUT_FORMAT -> INPUT_FORMAT_CLASS
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
