Copilot commented on code in PR #11071: URL: https://github.com/apache/gravitino/pull/11071#discussion_r3274020930
########## flink-connector/v1.20/flink/src/test/java/org/apache/gravitino/flink/connector/integration/test/hive/FlinkHiveCatalogIT120.java: ########## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.gravitino.flink.connector.integration.test.hive; + +import org.junit.jupiter.api.Assertions; +import org.junit.jupiter.api.Test; + +public class FlinkHiveCatalogIT120 extends FlinkHiveCatalogIT { + + @Override + @Test + public void testCreateGravitinoHiveCatalogRequireOptions() { + // Flink 1.20 reports missing required catalog options through IllegalArgumentException + // rather than the ValidationException thrown by older minor versions. + tableEnv.useCatalog(DEFAULT_CATALOG); + + String catalogName = "gravitino_hive_sql2"; + Assertions.assertThrows( + IllegalArgumentException.class, + () -> Review Comment: The Flink 1.20 override weakens the required-options coverage: it only asserts an IllegalArgumentException is thrown, but doesn’t validate that the failure is specifically due to the missing required option (e.g., message contains `hive.metastore.uris`). Adding an assertion on the exception message (similar to the base test) would prevent false positives where an unrelated IllegalArgumentException makes the test pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
