markhoerth commented on PR #10387:
URL: https://github.com/apache/gravitino/pull/10387#issuecomment-4522008674
Force-pushed a rebase of this PR onto current `main`. Summary of what
changed since the original push:
**Rebase**: 252 upstream commits had landed since the original branch base.
Resolved conflicts in four files where upstream had refactored around messages
I had touched (`CatalogHookDispatcher`, `JcasbinAuthorizer`,
`SchemaOperations`, `GravitinoConfig`).
**Spotless**: @yuqi1129 thanks for the pointer earlier. Ran `./gradlew
spotlessApply` and folded the formatting into the same commit. `spotlessCheck`
now passes clean.
**Scope expansion**: the original PR scoped to core/server/trino-connector
and called out catalogs as a follow-on. Since the branch was already open for
the rebase, I folded in the equivalent fixes across `api`, `authorizations`,
`bundles`, `catalogs` (paimon, hadoop-common, hive-metastore-common),
`clients`, and `iceberg`. Same mechanical patterns (`"Can not"` -> `"Cannot"`,
`"Fail to"` -> `"Failed to"`, etc.).
**Two real bug fixes** worth flagging in review, since these are not pure
polish:
1. `GCSTokenGenerator`: a runtime concatenation bug where `"... does not
exist." + path` produced output like `"... does not exist./path/to/file"`.
Changed the period to a colon-space.
2. `RangerHelper`: a malformed `LOG.warn` with `!, e: {}` cruft. Replaced
with a clean message and let SLF4J handle the trailing exception.
PR description has been updated with the same detail.
The PR is now 40 files / 116 insertions / 106 deletions, still one commit.
@jerryshao @yuqi1129, ready for another look when you have a moment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
