Copilot commented on code in PR #11207: URL: https://github.com/apache/gravitino/pull/11207#discussion_r3295762839
########## catalogs/catalog-jdbc-common/src/test/java/org/apache/gravitino/catalog/jdbc/TestJdbcViewCatalogOperations.java: ########## @@ -0,0 +1,169 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.gravitino.catalog.jdbc; + +import com.google.common.collect.ImmutableMap; +import java.sql.Connection; +import java.util.ArrayList; +import java.util.HashMap; +import java.util.List; +import java.util.Map; +import org.apache.gravitino.NameIdentifier; +import org.apache.gravitino.Namespace; +import org.apache.gravitino.catalog.jdbc.operation.JdbcViewOperations; +import org.apache.gravitino.exceptions.NoSuchSchemaException; +import org.apache.gravitino.exceptions.NoSuchViewException; +import org.apache.gravitino.rel.Column; +import org.apache.gravitino.rel.SQLRepresentation; +import org.apache.gravitino.rel.View; +import org.junit.jupiter.api.Assertions; +import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.Test; + +/** Tests for {@link JdbcViewCatalogOperations}. */ +public class TestJdbcViewCatalogOperations { + + private StubViewOperations stubViewOps; + private JdbcViewCatalogOperations catalogOps; + + @BeforeEach + void setUp() { + stubViewOps = new StubViewOperations(); + catalogOps = new JdbcViewCatalogOperations(stubViewOps, schema -> "existing_db".equals(schema)); + } + + @Test + public void testListViewsInExistingSchema() { + stubViewOps.addView("existing_db", "v1", "SELECT 1"); + stubViewOps.addView("existing_db", "v2", "SELECT 2"); + + NameIdentifier[] result = catalogOps.listViews(Namespace.of("existing_db")); + + Assertions.assertEquals(2, result.length); + List<String> names = + java.util.Arrays.stream(result) + .map(NameIdentifier::name) + .sorted() + .collect(java.util.stream.Collectors.toList()); + Assertions.assertEquals(java.util.Arrays.asList("v1", "v2"), names); Review Comment: `java.util.Arrays.stream(...)` and `java.util.stream.Collectors...` are used as fully-qualified names inside the method body. Please add the corresponding imports and use the simple class names to match the project’s Java style and keep the test easier to read. ########## catalogs/catalog-jdbc-common/src/main/java/org/apache/gravitino/catalog/jdbc/operation/JdbcViewOperations.java: ########## @@ -0,0 +1,240 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.gravitino.catalog.jdbc.operation; + +import com.google.common.collect.ImmutableMap; +import java.sql.Connection; +import java.sql.PreparedStatement; +import java.sql.ResultSet; +import java.sql.ResultSetMetaData; +import java.sql.SQLException; +import java.sql.Statement; +import java.util.ArrayList; +import java.util.List; +import java.util.Map; +import javax.sql.DataSource; +import org.apache.gravitino.catalog.jdbc.JdbcColumn; +import org.apache.gravitino.catalog.jdbc.JdbcView; +import org.apache.gravitino.catalog.jdbc.converter.JdbcExceptionConverter; +import org.apache.gravitino.catalog.jdbc.converter.JdbcTypeConverter; +import org.apache.gravitino.exceptions.NoSuchViewException; +import org.apache.gravitino.rel.Column; +import org.apache.gravitino.rel.SQLRepresentation; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** Abstract base class for database-specific JDBC view operations. */ +public abstract class JdbcViewOperations { + + protected static final Logger LOG = LoggerFactory.getLogger(JdbcViewOperations.class); + Review Comment: `LOG` is declared but never used in this class. Consider removing it (and the related imports) if it isn’t needed, to avoid dead code and keep the class minimal. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
