mchades commented on code in PR #11019: URL: https://github.com/apache/gravitino/pull/11019#discussion_r3300834133
########## clients/client-python/gravitino/api/rel/view.py: ########## Review Comment: The fields in the view should align with the Java API. ########## clients/client-python/gravitino/api/rel/view.py: ########## @@ -0,0 +1,60 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +"""View interface for Gravitino Python client.""" + +from abc import ABC, abstractmethod +from typing import Optional + +from gravitino.api.auditable import Auditable + + +class View(Auditable, ABC): + """The `View` interface defines the metadata of a view.""" + + @abstractmethod + def name(self) -> str: + """Get the name of the view. + + Returns: + str: The view name. + """ + + @abstractmethod + def comment(self) -> Optional[str]: + """Get the comment of the view. + + Returns: + Optional[str]: The view comment. + """ + return None + + @abstractmethod + def properties(self) -> dict[str, str]: + """Get the properties of the view. + + Returns: + dict[str, str]: The view properties. + """ + return {} + + @abstractmethod + def view_definition(self) -> Optional[str]: Review Comment: this should be `representations` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
