diqiu50 commented on code in PR #11186: URL: https://github.com/apache/gravitino/pull/11186#discussion_r3315137558
########## spark-connector/spark-common/src/main/java/org/apache/gravitino/spark/connector/glue/GravitinoGlueCredentialsProvider.java: ########## @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.gravitino.spark.connector.glue; + +import com.google.common.base.Preconditions; +import java.util.Map; +import software.amazon.awssdk.auth.credentials.AwsBasicCredentials; +import software.amazon.awssdk.auth.credentials.AwsCredentials; +import software.amazon.awssdk.auth.credentials.AwsCredentialsProvider; +import software.amazon.awssdk.core.exception.SdkClientException; + +/** + * AWS credentials provider for Iceberg {@code GlueCatalog} that reads static credentials from a + * properties map. + * + * <p>Iceberg 1.10+ loads credentials via {@code client.credentials-provider}. This class is + * instantiated dynamically by Iceberg's {@code AwsClientProperties} using the {@code create(Map)} + * static factory. The properties map contains the {@code client.credentials-provider.*} entries + * with their prefix stripped, i.e. {@code access-key-id} and {@code secret-access-key}. + */ +public class GravitinoGlueCredentialsProvider implements AwsCredentialsProvider { Review Comment: This two class live in separate modules. moving to catalog-common would required adding the AWS-SDK as a dependency to that moudle -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
