whua3 commented on issue #11303: URL: https://github.com/apache/gravitino/issues/11303#issuecomment-4587168679
PR is up: https://github.com/apache/gravitino/pull/11304 Implementation note: rather than the reference-counted holder sketched in the "Fix proposal" section above, the PR takes a simpler **lifecycle-bound** approach that matches Hadoop's own `FileSystem.CACHE` semantics — the cache no longer calls `fs.close()` on eviction; instead, every FileSystem ever created is tracked and closed exactly once when `BaseGVFSOperations#close()` runs (GVFS shutdown). This avoids wrapping streams / leaking on missed releases, while fixing the same race. The opt-in switch `fs.gravitino.fileset.cache.closeOnEviction` (default `false`) is included as agreed, so the legacy "close on eviction" behaviour stays available as a fallback. Scope is intentionally limited to the client (`clients/filesystem-hadoop3`). cc @mchades @xloya — would appreciate a review when you have time, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
