ningsh7 commented on code in PR #11270:
URL: https://github.com/apache/gravitino/pull/11270#discussion_r3331303470
##########
iceberg/iceberg-common/src/main/java/org/apache/gravitino/iceberg/common/IcebergConfig.java:
##########
@@ -230,6 +234,32 @@ public class IcebergConfig extends Config implements
OverwriteDefaultConfig {
.booleanConf()
.createWithDefault(true);
+ /** HTTP connection timeout in milliseconds for the REST catalog backend. */
+ public static final ConfigEntry<Integer>
REST_CATALOG_BACKEND_CLIENT_CONNECTION_TIMEOUT_MS =
+ new
ConfigBuilder(IcebergConstants.REST_CATALOG_BACKEND_CLIENT_CONNECTION_TIMEOUT_MS)
+ .alternatives(
+ ImmutableList.of(
+ IcebergConstants.ICEBERG_REST_CLIENT_CONNECTION_TIMEOUT_MS,
Review Comment:
Let me removed them from the alternatives and kept only the Gravitino-facing
keys, with the actual Iceberg keys (`rest.client.connection-timeout-ms` and
`rest.client.socket-timeout-ms`) as aliases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
