sunyuhan1998 commented on code in PR #11274:
URL: https://github.com/apache/gravitino/pull/11274#discussion_r3331856699
##########
clients/client-python/tests/integration/test_role_management.py:
##########
@@ -120,3 +120,43 @@ def test_list_role_names(self):
names = self._gravitino_client.list_role_names()
self.assertIn("role_a", names)
self.assertIn("role_b", names)
+
+ def test_grant_revoke_roles_to_user(self):
+ self._gravitino_client.create_role("user_role")
+ self._gravitino_client.add_user("alice")
+
+ granted = self._gravitino_client.grant_roles_to_user(["user_role"],
"alice")
+ self.assertIn("user_role", granted.roles())
+
+ revoked = self._gravitino_client.revoke_roles_from_user(["user_role"],
"alice")
+ self.assertNotIn("user_role", revoked.roles())
+
+ def test_grant_revoke_roles_to_group(self):
+ self._gravitino_client.create_role("group_role")
+ self._gravitino_client.add_group("engineers")
+
+ granted = self._gravitino_client.grant_roles_to_group(
+ ["group_role"], "engineers"
+ )
+ self.assertIn("group_role", granted.roles())
+
+ revoked = self._gravitino_client.revoke_roles_from_group(
+ ["group_role"], "engineers"
+ )
+ self.assertNotIn("group_role", revoked.roles())
+
+ def test_grant_revoke_privileges_to_role(self):
+ self._gravitino_client.create_role("priv_role")
+
+ privileges = [Privileges.allow("USE_CATALOG")]
+ securable_obj = SecurableObjects.of_metalake(self._metalake_name,
privileges)
+
+ granted = self._gravitino_client.grant_privileges_to_role(
+ "priv_role", securable_obj, privileges
+ )
+ self.assertEqual("priv_role", granted.name())
+
+ revoked = self._gravitino_client.revoke_privileges_from_role(
+ "priv_role", securable_obj, privileges
+ )
+ self.assertEqual("priv_role", revoked.name())
Review Comment:
Done. The test now asserts that the granted role's securable objects
contain the `USE_CATALOG` privilege, and after revoking, the privilege is no
longer present.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
