ningsh7 commented on PR #11180:
URL: https://github.com/apache/gravitino/pull/11180#issuecomment-4593732921
> Potential regression: `compileDistribution` now declares two outputs
(`distribution/package` and `distribution/package-all`), but
`assembleDistribution` still does `compileDistribution.map {
it.outputs.files.single() }`. That assumes exactly one output and will fail
once the provider is resolved. Could we switch `assembleDistribution` to an
explicit source such as `from(distributionPackageDir)` instead of relying on
`single()`?
@yuqi1129 Good point, I have changed `assembleDistribution` to use
`from(distributionPackageDir)` explicitly instead of
`compileDistribution.outputs.files.single()`.
I also added `dependsOn(compileDistribution)` because the previous
provider-based `from(...)` carried an implicit dependency on
`compileDistribution`. After switching to the explicit directory source, the
dry-run showed `compileDistribution` was no longer scheduled unless we declare
that dependency explicitly.
Verified with `assembleDistribution --dry-run` and the real
`assembleDistribution` build.
Please check again thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
