dennismdejong opened a new issue, #11667:
URL: https://github.com/apache/gravitino/issues/11667
**What would you like to be improved?**
The Gravitino Helm chart template
(`dev/charts/gravitino/resources/config/gravitino.conf`) currently supports 11
OAuth configuration properties, but is missing 5 properties that were added to
the server in v1.2.0 and v1.3.0:
Missing properties:
| Property | Server version | Config key |
|---|---|---|
| `principalMapper` | v1.2.0 |
`gravitino.authenticator.oauth.principalMapper` |
| `principalMapper.regex.pattern` | v1.2.0 |
`gravitino.authenticator.oauth.principalMapper.regex.pattern` |
| `groupsFields` | v1.3.0 | `gravitino.authenticator.oauth.groupsFields` |
| `groupMapper` | v1.3.0 | `gravitino.authenticator.oauth.groupMapper` |
| `groupMapper.regex.pattern` | v1.3.0 |
`gravitino.authenticator.oauth.groupMapper.regex.pattern` |
Users currently must use the `additionalConfigItems` escape hatch to
configure these, which is error-prone and not discoverable.
**How should we improve?**
Add the missing 5 properties to the Helm chart:
1. Add conditional blocks to
`dev/charts/gravitino/resources/config/gravitino.conf`:
```
{{- if .groupsFields }}
gravitino.authenticator.oauth.groupsFields = {{ .groupsFields }}
{{- end }}
{{- if .groupMapper }}
gravitino.authenticator.oauth.groupMapper = {{ .groupMapper }}
{{- end }}
{{- if .groupMapperRegexPattern }}
gravitino.authenticator.oauth.groupMapper.regex.pattern = {{
.groupMapperRegexPattern }}
{{- end }}
{{- if .principalMapper }}
gravitino.authenticator.oauth.principalMapper = {{ .principalMapper }}
{{- end }}
{{- if .principalMapperRegexPattern }}
gravitino.authenticator.oauth.principalMapper.regex.pattern = {{
.principalMapperRegexPattern }}
{{- end }}
```
2. Add defaults to `dev/charts/gravitino/values.yaml`:
```yaml
groupsFields: "groups"
groupMapper: "regex"
groupMapperRegexPattern: "^(.*)$"
principalMapper: "regex"
principalMapperRegexPattern: "^(.*)$"
```
3. Add corresponding tests to
`dev/charts/gravitino/tests/configmap_test.yaml`.
This makes the Helm chart fully feature-complete with the server-side OAuth
configuration capabilities introduced in v1.2.0 and v1.3.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
