diqiu50 commented on code in PR #11669:
URL: https://github.com/apache/gravitino/pull/11669#discussion_r3419885956


##########
docs/lakehouse-paimon-catalog.md:
##########
@@ -57,6 +57,7 @@ Builds with Apache Paimon `1.2`.
 
 :::note
 - If you want to use the `oss` or `s3` warehouse, you need to place related 
jars in the `catalogs/lakehouse-paimon/lib` directory, more information can be 
found in the [Paimon 
S3](https://paimon.apache.org/docs/1.2/maintenance/filesystems/#s3).
+- If you use an S3 warehouse, also download 
[`gravitino-aws-<version>.jar`](https://mvnrepository.com/artifact/org.apache.gravitino/gravitino-aws)
 and place it in the `catalogs/lakehouse-paimon/libs` directory to enable 
credential vending. For OSS, use 
[`gravitino-aliyun-<version>.jar`](https://mvnrepository.com/artifact/org.apache.gravitino/gravitino-aliyun)
 instead.

Review Comment:
   I think it’s sufficient to document Credential Vending in the security 
documentation. We shouldn’t add catalog-specific notes here. If we add this 
note for Paimon, we’ll need to add the same note for every catalog.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to