kevinw66 commented on code in PR #12040: URL: https://github.com/apache/gravitino/pull/12040#discussion_r3601590037
########## clients/client-python/gravitino/api/rel/view_change.py: ########## @@ -0,0 +1,214 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from abc import ABC +from dataclasses import dataclass +from typing import Optional + +from gravitino.api.rel.column import Column +from gravitino.api.rel.representation import Representation +from gravitino.utils.precondition import Precondition + + +class ViewChange(ABC): + """Defines changes that can be applied to a view.""" + + @staticmethod + def rename(new_name: str) -> "RenameView": + """Create a change for renaming a view.""" + return RenameView(new_name) + + @staticmethod + def set_property(property_name: str, value: str) -> "SetProperty": + """Create a change for setting a view property.""" + return SetProperty(property_name, value) + + @staticmethod + def remove_property(property_name: str) -> "RemoveProperty": + """Create a change for removing a view property.""" + return RemoveProperty(property_name) + + @staticmethod + def replace_view( + columns: list[Column], + representations: list[Representation], + default_catalog: Optional[str] = None, + default_schema: Optional[str] = None, + comment: Optional[str] = None, + ) -> "ReplaceView": + """Create a change for replacing the view body.""" + return ReplaceView( + columns, representations, default_catalog, default_schema, comment + ) + + +@dataclass(frozen=True) +class RenameView(ViewChange): + """A ViewChange to rename a view.""" + + _new_name: str + + def __post_init__(self): + Precondition.check_string_not_empty( + self._new_name, "newName must not be null or empty" + ) + + def new_name(self) -> str: + """Returns the new view name.""" + return self._new_name + + def __eq__(self, other: object) -> bool: + if not isinstance(other, RenameView): + return False + return self._new_name == other.new_name() + + def __hash__(self) -> int: + return hash(self._new_name) + + def __str__(self) -> str: + return f"RENAMEVIEW {self._new_name}" + + +@dataclass(frozen=True) +class SetProperty(ViewChange): + """A ViewChange to set a view property.""" + + _property: str + _value: str + + def __post_init__(self): + Precondition.check_string_not_empty( + self._property, "property must not be null or empty" + ) + Review Comment: This mirrors Java ViewChange.SetProperty, which validates only the property name. ```java // class ViewChange.SetProperty private SetProperty(String property, String value) { Preconditions.checkArgument( property != null && !property.isEmpty(), "property must not be null or empty"); this.property = property; this.value = value; } ``` But I also noticed that ViewUpdateRequest validates value as non-null rather than non-empty, and this validation is already invoked in the request-building path, so the current flow seems correct. I’m fine with adding the same non-null check earlier in ViewChange.SetProperty, but if we do that here, Java ViewChange.SetProperty should be updated consistently as well. ```java // class SetViewPropertyRequest public void validate() throws IllegalArgumentException { Preconditions.checkArgument( StringUtils.isNotBlank(property), "\"property\" field is required and cannot be empty"); Preconditions.checkArgument(value != null, "\"value\" field is required and cannot be null"); } ``` Also, neither the Java nor Python TableChange.SetProperty validates the value, so an empty string is currently allowed. Java Code for example: ```java // class TableChange.SetProperty public SetProperty(String property, String value) { this.property = property; this.value = value; } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
