nevzheng commented on PR #10975:
URL: https://github.com/apache/gravitino/pull/10975#issuecomment-5012071233
@Octavi00
Hi, thanks for the PR.
**Blocking:** This needs committed end-to-end mTLS tests that perform a real
handshake and validate the behavior: a trusted client certificate succeeds,
while a missing or untrusted client certificate is rejected.
**Architecture:** I don’t think `TLSConfigurer` should be added to
`GravitinoAdminClient`, `GravitinoClient`, or `GravitinoClientBase`. We are
injecting behavior into the HTTP transport, not extending the Gravitino client
API.
Please add or extend a shared builder so it can configure the
`HTTPClient.Builder` directly:
```java
builder.configureHttp(
http -> http.withTlsConfigurer(tlsConfigurer));
```
TLS then remains owned by `HTTPClient`, without being passed through the
Gravitino client hierarchy. As a follow-up, other HTTP-specific properties such
as headers and authentication can move into the same construction path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
