roryqi commented on code in PR #12092:
URL: https://github.com/apache/gravitino/pull/12092#discussion_r3612962341
##########
.github/workflows/contrib-catalog-test.yml:
##########
@@ -0,0 +1,132 @@
+name: Contrib Catalog Test
+
+on:
+ push:
+ branches: [ "main", "branch-*" ]
+ pull_request:
+ branches: [ "main", "branch-*" ]
+ workflow_dispatch:
+
+concurrency:
+ group: ${{ github.workflow }}-${{ github.event.pull_request.number ||
github.ref }}
+ cancel-in-progress: true
+
+jobs:
+ changes:
+ runs-on: ubuntu-22.04
+ steps:
+ - uses: actions/checkout@v4
+ with:
+ fetch-depth: 0
+ - uses: dorny/paths-filter@fbd0ab8f3e69293af611ebaee6363fc25e6d187d
+ id: filter
+ with:
+ filters: |
+ source_changes:
+ - .github/workflows/contrib-catalog-test.yml
+ - catalogs-contrib/**
+ - catalogs/catalog-common/**
+ - catalogs/catalog-jdbc-common/**
+ - dev/**
+ - gradle/**
+ - integration-test-common/**
+ - build.gradle.kts
+ - gradle.properties
+ - gradlew
+ - settings.gradle.kts
+ - name: Detect changed catalogs-contrib modules
+ id: contrib
+ run: |
+ if [ "${{ github.event_name }}" = "pull_request" ]; then
+ BASE_SHA="${{ github.event.pull_request.base.sha }}"
+ HEAD_SHA="${{ github.event.pull_request.head.sha }}"
+ else
+ BASE_SHA="${{ github.event.before }}"
+ HEAD_SHA="${{ github.sha }}"
+ fi
+
+ if [ -z "$BASE_SHA" ] || [ "$BASE_SHA" =
"0000000000000000000000000000000000000000" ]; then
+ BASE_SHA="$(git rev-list --max-parents=0 "$HEAD_SHA" | tail -n 1)"
+ fi
+
+ MERGE_BASE_SHA="$(git merge-base "$BASE_SHA" "$HEAD_SHA" || true)"
+ if [ -z "$MERGE_BASE_SHA" ]; then
+ MERGE_BASE_SHA="$BASE_SHA"
+ fi
+
+ CHANGED_FILES="$(git diff --name-only "$MERGE_BASE_SHA" "$HEAD_SHA")"
+ CHANGED_MODULES="$(echo "$CHANGED_FILES" | awk -F/
'/^catalogs-contrib\/[^/]+\// {print $2}' | sort -u | xargs)"
+
+ if echo "$CHANGED_FILES" | grep -Eq
'^(\.github/workflows/contrib-catalog-test.yml|catalogs-contrib/build.gradle.kts|catalogs/catalog-common/|catalogs/catalog-jdbc-common/|dev/|gradle/|integration-test-common/|build.gradle.kts|gradle.properties|gradlew|settings.gradle.kts)';
then
+ CHANGED_MODULES="__all__"
+ fi
+
+ echo "changed_catalogs_contrib_modules=$CHANGED_MODULES" >>
"$GITHUB_OUTPUT"
+ outputs:
+ source_changes: ${{ steps.filter.outputs.source_changes }}
+ changed_catalogs_contrib_modules: ${{
steps.contrib.outputs.changed_catalogs_contrib_modules }}
+
+ contrib-catalog-test:
+ needs: changes
+ if: needs.changes.outputs.source_changes == 'true' &&
needs.changes.outputs.changed_catalogs_contrib_modules != ''
+ runs-on: ubuntu-22.04
+ timeout-minutes: 90
+ steps:
+ - uses: actions/checkout@v4
+
+ - uses: actions/setup-java@v4
+ with:
+ java-version: 17
+ distribution: 'temurin'
+ cache: 'gradle'
+
+ - name: Set up QEMU
+ uses:
docker/setup-qemu-action@ce360397dd3f832beb865e1373c09c0e9f86d70a # v4.0.0
+
+ - name: Check required command
+ run: |
+ dev/ci/check_commands.sh
+
+ - name: Free up disk space
+ run: |
+ dev/ci/util_free_space.sh
+
+ - name: Install dependencies
+ run: |
+ wget
https://nz2.archive.ubuntu.com/ubuntu/pool/main/o/openssl/libssl1.1_1.1.1f-1ubuntu2_amd64.deb
+ sudo dpkg -i libssl1.1_1.1.1f-1ubuntu2_amd64.deb
+
+ - name: Run contrib catalog tests
+ id: contribCatalogTest
+ run: |
+ CHANGED_CONTRIB_MODULES="${{
needs.changes.outputs.changed_catalogs_contrib_modules }}"
+
+ if [ "$CHANGED_CONTRIB_MODULES" = "__all__" ]; then
+ CONTRIB_MODULES="$(find catalogs-contrib -mindepth 1 -maxdepth 1
-type d -name 'catalog-*' -exec basename {} \; | sort)"
+ else
+ CONTRIB_MODULES="$CHANGED_CONTRIB_MODULES"
+ fi
+
+ gradle_args=()
+ for module in $CONTRIB_MODULES; do
+ if [ -d "catalogs-contrib/$module" ]; then
+ gradle_args+=(":catalogs-contrib:$module:test")
+ fi
+ done
+
+ if [ "${#gradle_args[@]}" -eq 0 ]; then
+ echo "No changed contrib catalog test tasks."
+ exit 0
+ fi
+
+ ./gradlew "${gradle_args[@]}" -PskipITs -PskipDockerTests=false
-PskipWeb=true
Review Comment:
Moved the remaining `catalogs-contrib` routing out of Backend Integration
Test. The backend workflow no longer watches `catalogs-contrib/**` or passes
`changed-catalogs-contrib-modules`, the reusable backend action excludes all
`catalogs-contrib` test tasks, and `Contrib Catalog Test` now runs contrib
module test tasks without `-PskipITs` so
`catalogs-contrib/**/integration/test/**` is handled there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
