mchades commented on code in PR #12098:
URL: https://github.com/apache/gravitino/pull/12098#discussion_r3613723963
##########
core/src/main/java/org/apache/gravitino/catalog/SchemaNormalizeDispatcher.java:
##########
@@ -57,10 +56,9 @@ public NameIdentifier[] listSchemas(Namespace namespace)
throws NoSuchCatalogExc
NameIdentifier.of(namespace.levels())));
}
- NameIdentifier[] identifiers = dispatcher.listSchemas(namespace);
- // The constraints of the name spec may be more strict than underlying
catalog,
- // and for compatibility reasons, we only apply case-sensitive
capabilities here.
- return normalizeCaseSensitive(identifiers);
+ // listSchemas() is assumed to already return names in their canonical,
legal form, so no
+ // re-normalization is applied here.
+ return dispatcher.listSchemas(namespace);
Review Comment:
We should not return the underlying catalog result directly here.
`Capability` defines the naming rules exposed by Gravitino, so list results
must still be normalized at the core boundary. Otherwise, backend-native names
may leak through and become inconsistent with other schema operations. Please
keep `normalizeCaseSensitive(identifiers)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
