LuciferYang commented on code in PR #12107:
URL: https://github.com/apache/gravitino/pull/12107#discussion_r3613795112
##########
common/src/main/java/org/apache/gravitino/auth/KerberosUtils.java:
##########
@@ -134,7 +134,11 @@ public AppConfigurationEntry[]
getAppConfigurationEntry(String name) {
options.put("doNotPrompt", "true");
options.put("refreshKrb5Config", "true");
options.put("isInitiator", "true");
- options.put("debug", "true");
+ // Enabling the login module's debug prints Kerberos details (principal,
keytab path, etc.)
+ // to stdout on every login, which is noise/info-leak in normal client
use. Gate it on the
+ // standard JDK Kerberos debug switch (-Dsun.security.krb5.debug=true)
so it stays off by
+ // default but turns on when someone is already debugging Kerberos.
+ options.put("debug",
String.valueOf(Boolean.getBoolean("sun.security.krb5.debug")));
Review Comment:
Let me know if we need to define a new config separately. Besides, this
change only modifies this single feature toggle, so I haven’t added any
additional test cases. Is that acceptable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
