bharos commented on code in PR #12096: URL: https://github.com/apache/gravitino/pull/12096#discussion_r3625524777
########## common/src/main/java/org/apache/gravitino/auth/ActiveRolesContext.java: ########## @@ -0,0 +1,60 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.gravitino.auth; + +import java.util.Objects; + +/** + * Request-scoped holder for the caller's declared {@link ActiveRoles} (role assumption). + * + * <p>Backed by a {@link ThreadLocal}; the value must be {@link #clear() cleared} when the request + * completes so it never leaks to the next request on a pooled thread. + */ +public final class ActiveRolesContext { Review Comment: Done , moved active roles onto UserPrincipal instead of a thread-local. Since UserPrincipal is immutable, `withActiveRoles(...)` returns a copy with the roles attached, and the filter binds that copy before doAs. Hope creating and returning a copy is OK here ? Otherwise please let me know if you think of any better way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
