roryqi commented on code in PR #12162:
URL: https://github.com/apache/gravitino/pull/12162#discussion_r3637824423
##########
api/src/main/java/org/apache/gravitino/tag/TagOperations.java:
##########
@@ -70,6 +70,22 @@ public interface TagOperations {
Tag createTag(String name, String comment, Map<String, String> properties)
throws TagAlreadyExistsException;
+ /**
+ * Create a tag under a metalake.
+ *
+ * @param name The name of the tag.
+ * @param comment The comment of the tag.
+ * @param properties The properties of the tag.
+ * @param allowedValues The allowed assignment values of the tag.
+ * @return The created tag.
+ * @throws TagAlreadyExistsException If the tag already exists.
+ */
+ default Tag createTag(
+ String name, String comment, Map<String, String> properties, String[]
allowedValues)
+ throws TagAlreadyExistsException {
+ return createTag(name, comment, properties);
Review Comment:
Changed in this PR rather than deferring it. TagOperations.createTag now
accepts TagValueConstraint instead of a raw String[]; the default
implementation only delegates for null/anyValue and rejects non-default
constraints unless the concrete implementation supports them.
##########
api/src/main/java/org/apache/gravitino/tag/TagValue.java:
##########
@@ -0,0 +1,151 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.gravitino.tag;
+
+import java.util.Objects;
+import java.util.Optional;
+import javax.annotation.Nullable;
+import org.apache.gravitino.annotation.Evolving;
+
+/** Represents one tag assignment value in tag association requests. */
+@Evolving
+public final class TagValue {
+
+ private String name = "";
+
+ @Nullable private String value;
+
+ /** Creates an empty tag assignment value for deserialization. */
+ public TagValue() {}
+
+ /**
+ * Creates a tag assignment value.
+ *
+ * @param name The tag name.
+ * @param value The assignment value. Null means a valueless tag assignment.
+ */
+ public TagValue(String name, @Nullable String value) {
+ this.name = name == null ? "" : name;
Review Comment:
There is no valid scenario for an empty name. The empty default was only to
make the first draft easy to deserialize, but this API type no longer handles
JSON deserialization directly. TagValue now uses a private constructor and
static factories that validate non-blank tag names.
##########
api/src/main/java/org/apache/gravitino/tag/Tag.java:
##########
@@ -54,6 +54,26 @@ public interface Tag extends Auditable {
*/
Map<String, String> properties();
+ /**
+ * @return The allowed assignment values of the tag. {@link
Optional#empty()} means the tag is
+ * unrestricted. A present empty array means the tag only accepts
valueless assignments.
+ */
+ default Optional<String[]> allowedValues() {
+ return Optional.empty();
+ }
+
+ /**
+ * Returns the assignment values of the tag in the current metadata-object
context.
+ *
+ * <p>The return value is present only when the tag is returned for a
metadata object. A present
+ * empty array means the tag is directly or effectively assigned without
values.
Review Comment:
Updated this part as Tag.assignment(), returning Optional<TagAssignment>.
Optional.empty() means the tag has no metadata-object assignment context;
TagAssignment.withoutValues() means assigned without values;
TagAssignment.ofValues(...) means assigned with one or more values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
