hutiefang76 commented on code in PR #11877:
URL: https://github.com/apache/gravitino/pull/11877#discussion_r3665437498
##########
catalogs/catalog-jdbc-doris/src/main/java/org/apache/gravitino/catalog/doris/operation/DorisTableOperations.java:
##########
@@ -180,7 +181,8 @@ Map<String, String> appendNecessaryProperties(Map<String,
String> properties) {
// If the backend server is less than
DEFAULT_REPLICATION_FACTOR_IN_SERVER_SIDE (3), we need to
// set the property 'replication_num' to 1 explicitly.
- if (!resultMap.containsKey(REPLICATION_FACTOR)) {
+ if (!resultMap.containsKey(REPLICATION_FACTOR)
+ && !resultMap.containsKey(REPLICATION_ALLOCATION)) {
Review Comment:
Doris does not define a successful precedence for this combination: it
consumes `replication_num` and later rejects the remaining
`replication_allocation` as an unknown property. I updated Gravitino to fail
fast with a clear error when both are present, rather than silently choosing
one. The change includes a regression test for the conflicting pair and
documents the mutual-exclusion rule. I also rebased the PR onto the current
`main`; the full `catalog-jdbc-doris` non-Docker test suite and Spotless check
pass locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
