laserninja commented on PR #11206: URL: https://github.com/apache/gravitino/pull/11206#issuecomment-5183587754
@roryqi Done - added `docs/table-maintenance-service/expire-snapshots.md` in b6241fe. It covers: - Job template parameters (`older_than`, `retain_last`, `stream_results`, `spark_conf`) - REST API usage examples for each scenario - Generated Iceberg SQL for the `expire_snapshots` procedure - Output format and verification steps - Relationship to the other built-in maintenance jobs Also addressed the earlier review comments in 774d6f2: - Extracted `IcebergJobUtils` for the SQL escaping / argument parsing helpers shared with `IcebergRewriteDataFilesJob` (@jerryshao) - `escapeSqlIdentifier()` now backtick-quotes the identifier instead of only doubling internal backticks - `--stream-results` is now a unix-style boolean flag (@jerryshao) PTAL when you get a chance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
