bharos opened a new pull request, #12368:
URL: https://github.com/apache/gravitino/pull/12368

   ### What changes were proposed in this pull request?
   
   The `--include-tool-tags` help text advertised 8 tags, but tools are 
registered with 12. This adds the four missing ones — `job`, `partition`, 
`statistic` and `view` — and orders the list alphabetically so it is easier to 
keep in sync.
   
   It also drops a stray unbalanced `)` at the end of the same message.
   
   ```
   - support tags:[catalog, schema, table, topic, model, fileset, tag, policy]
   + support tags:[catalog, fileset, job, model, partition, policy, schema,
   +               statistic, table, tag, topic, view]
   ```
   
   ### Why are the changes needed?
   
   `--include-tool-tags` is the only way to restrict which tools the MCP server 
exposes. Filtering on `job`, `partition`, `statistic` or `view` already works, 
but because those tags are absent from the help text they are effectively 
undiscoverable from the CLI.
   
   ### Does this PR introduce _any_ user-facing change?
   
   Yes — corrected `--help` output. No behaviour change.
   
   ### How was this patch tested?
   
   Confirmed `--help` renders the full list, and cross-checked the documented 
tags against the tags actually registered on the `FastMCP` instance after 
`load_tools()` (67 tools, 12 distinct tags). They now match exactly; running 
the same check against the previous text reports `job`, `partition`, 
`statistic` and `view` as missing.
   
   Existing `mcp-server` checks pass: `black --check` (79 files), `pylint 
mcp_server` (10.00/10) and 167 unit tests.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to