kevinw66 commented on code in PR #12323:
URL: https://github.com/apache/gravitino/pull/12323#discussion_r3748015340
##########
clients/client-python/gravitino/dto/audit_dto.py:
##########
@@ -73,7 +114,7 @@ def creator(self) -> str:
"""
return self._creator
- def create_time(self) -> str:
+ def create_time(self) -> datetime:
Review Comment:
@jerryshao I prefer to keep the current signatures in this PR.
Because the [Audit
API](https://github.com/apache/gravitino/blob/main/clients/client-python/gravitino/api/audit.py#L35)
already defines `create_time()` and `last_modified_time()` as returning
`datetime`. Before this PR, `AuditDTO` did not follow that contract and
returned `str`; this PR only aligns `AuditDTO` with the existing API contract
without changing the API itself.
Also, `creator()` and `last_modifier()` follow the same existing pattern:
their backing fields are optional, while their return types remain the
non-optional types defined by `Audit`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
