lasdf1234 commented on code in PR #12366:
URL: https://github.com/apache/gravitino/pull/12366#discussion_r3749279800
##########
common/src/main/java/org/apache/gravitino/dto/requests/FilesetCreateRequest.java:
##########
@@ -64,6 +67,36 @@ public class FilesetCreateRequest implements RESTRequest {
@JsonProperty("properties")
private Map<String, String> properties;
+ @Nullable
+ @JsonInclude(JsonInclude.Include.NON_EMPTY)
+ @JsonProperty("secretBindings")
+ private Map<String, SecretBindingDTO> secretBindings;
+
+ @Nullable
+ @JsonInclude(JsonInclude.Include.NON_EMPTY)
+ @JsonProperty("secretReferences")
+ private Map<String, SecretReferenceDTO> secretReferences;
+
+ /**
+ * Constructor for FilesetCreateRequest without secret maps.
+ *
+ * @param name The name of the fileset.
+ * @param comment The comment of the fileset.
+ * @param type The type of the fileset.
+ * @param storageLocation The storage location of the fileset.
+ * @param storageLocations The storage locations of the fileset.
+ * @param properties The properties of the fileset.
+ */
+ public FilesetCreateRequest(
+ String name,
+ String comment,
+ Fileset.Type type,
+ String storageLocation,
+ Map<String, String> storageLocations,
+ Map<String, String> properties) {
+ this(name, comment, type, storageLocation, storageLocations, properties,
null, null);
Review Comment:
Yes, I agree. Use Empty collections instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
