nevzheng commented on PR #12389: URL: https://github.com/apache/gravitino/pull/12389#issuecomment-5241702607
> Could u avoid uploading the binary files? You should generate them in the tests instead of uploading them into the repo. Repo should manage the text files instead of binary files. Although they are not large, it still isn't a good practice. @roryqi I recommend just submitting the binary files as is. We do not need a more complex scheme to manage key files at this time. We have other concerns to address. The principle I’d like to highlight here is to keep things as simple as they need to be. If we ask for a change to generate key files every time that isn’t required we just delay the project without a product requirement that we need to satisfy. In my experience, storing test, artifacts alongside tests like this is perfectly normal. can you elaborate on your concerns? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
