Copilot commented on code in PR #12460:
URL: https://github.com/apache/gravitino/pull/12460#discussion_r3774804989
##########
.github/workflows/multi-instance-consistency-test.yml:
##########
@@ -34,6 +33,15 @@ jobs:
--health-interval=5s
--health-timeout=3s
--health-retries=20
+ kafka:
+ image: apache/kafka:3.9.1
+ ports:
+ - 9092:9092
+ options: >-
+ --health-cmd="/opt/kafka/bin/kafka-topics.sh --bootstrap-server
localhost:9092 --list"
+ --health-interval=5s
+ --health-timeout=10s
+ --health-retries=20
Review Comment:
The `apache/kafka` image is started without the KRaft-related environment
variables that this repo’s Testcontainers setup uses to boot Kafka. Without
these env vars, the Kafka service may fail to start (or start with unexpected
listeners), making the workflow flaky or broken.
##########
dev/ci/setup_multi_instance.sh:
##########
@@ -41,6 +41,11 @@ curl -fsSL "${JDBC_URL}" -o "${JDBC_JAR}"
EXPECTED_SHA1="$(curl -fsSL "${JDBC_URL}.sha1")"
echo "${EXPECTED_SHA1} ${JDBC_JAR}" | sha1sum --check
+# The entity-cache consistency test uses an Iceberg JDBC catalog. Catalogs have
+# isolated class loaders, so the driver must also be present in the catalog's
+# own libs directory before the distribution is copied for instance B.
+cp "${JDBC_JAR}" distribution/package/catalogs/lakehouse-iceberg/libs/
Review Comment:
`cp "${JDBC_JAR}" distribution/package/catalogs/lakehouse-iceberg/libs/`
will abort the script (set -e) if the Iceberg catalog libs directory is missing
in the assembled distribution. Create the destination directory explicitly to
make the CI setup robust across packaging/layout changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
