yuqi1129 commented on code in PR #12455:
URL: https://github.com/apache/gravitino/pull/12455#discussion_r3803912565
##########
core/src/main/java/org/apache/gravitino/catalog/CatalogManager.java:
##########
@@ -984,6 +984,13 @@ public boolean dropCatalog(NameIdentifier ident, boolean
force)
} catch (NoSuchMetalakeException | NoSuchCatalogException ignored) {
return false;
+ } catch (NoSuchEntityException ignored) {
Review Comment:
Fixed in 44c3bebdd1. `createCatalog` now converts a `NoSuchEntityException`
from `store.put` into `NoSuchMetalakeException`. Cleanup is armed only after
the put succeeds, so the missing-parent path cannot be masked by a cleanup
delete. Added a regression test for the exception mapping and no-cleanup
behavior.
##########
core/src/main/java/org/apache/gravitino/storage/relational/service/CatalogMetaService.java:
##########
@@ -374,6 +401,98 @@ public boolean deleteCatalog(NameIdentifier identifier,
boolean cascade) {
return true;
}
+ /**
Review Comment:
Fixed in 44c3bebdd1. Moved the four private helpers after all public methods
in `CatalogMetaService`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
