lasdf1234 opened a new pull request, #12674:
URL: https://github.com/apache/gravitino/pull/12674
### What changes were proposed in this pull request?
Follow-up to #12646 (fileset alter). Adds catalog / schema alter support for
`setSecretBinding` / `setSecretReference`:
- API / DTO / OpenAPI / Java & Python clients: new `CatalogChange` and
`SchemaChange` types
- `CatalogManager` / `SchemaOperationDispatcher`: local
`prepare*SecretChanges` loops calling existing `SecretManager` alter helpers,
rewriting secret ops to `setProperty` / `removeProperty` (same pattern as
`FilesetOperationDispatcher`)
- `OperationDispatcher`: validate alter upserts for schema secret changes
- Unit tests for alter removeProperty write-through cleanup and JSON serde
### Why are the changes needed?
Create-time `secretBindings` / `secretReferences` for catalog and schema are
already on `main` (#12420). Catalog and schema alter still need the typed
secret update contract from the entity-secrets design (ยง5.9.4).
Fix: #12297
### Does this PR introduce _any_ user-facing change?
Yes. Catalog and schema alter APIs / REST update requests gain
`setSecretBinding` and `setSecretReference`.
### How was this patch tested?
```bash
./gradlew spotlessApply
./gradlew :core:test \
--tests 'org.apache.gravitino.secret.TestSecretManagerAlter' \
--tests
'org.apache.gravitino.catalog.TestCatalogManager.testAlterRemovePropertyDeletesWriteThroughSecret'
\
--tests
'org.apache.gravitino.catalog.TestCatalogManager.testSecretRollback' \
--tests
'org.apache.gravitino.catalog.TestSchemaOperationDispatcher.testAlterRemovePropertyDeletesWriteThroughSecret'
\
--tests
'org.apache.gravitino.catalog.TestSchemaOperationDispatcher.testCreateAndAlterSchemaRejectMaskedPlaceholder'
\
:common:test --tests 'org.apache.gravitino.json.TestRequestJsonSerDe' \
:docs:build \
-PskipITs
```
Made with [Cursor](https://cursor.com)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
