Copilot commented on code in PR #12697:
URL: https://github.com/apache/gravitino/pull/12697#discussion_r3877369334
##########
trino-connector/integration-test/trino-test-tools/download_jar.sh:
##########
@@ -54,10 +54,10 @@ download_mysql_jar() {
}
download_postgresql_jar() {
- download_jar "postgresql-42.7.0.jar" \
- "https://jdbc.postgresql.org/download/postgresql-42.7.0.jar"; \
+ download_jar "postgresql-42.7.11.jar" \
+ "https://jdbc.postgresql.org/download/postgresql-42.7.11.jar"; \
"$GRAVITINO_SERVER_DIR/catalogs/jdbc-postgresql/libs"
- cp -rp
$GRAVITINO_SERVER_DIR/catalogs/jdbc-postgresql/libs/postgresql-42.7.0.jar
$GRAVITINO_SERVER_DIR/catalogs/lakehouse-iceberg/libs
+ cp -rp
$GRAVITINO_SERVER_DIR/catalogs/jdbc-postgresql/libs/postgresql-42.7.11.jar
$GRAVITINO_SERVER_DIR/catalogs/lakehouse-iceberg/libs
}
Review Comment:
The PostgreSQL JAR name is hardcoded three times (file name, URL, and cp
source), which makes future upgrades error-prone (easy to update one but miss
another). Consider deriving the JAR name from a single version variable (and
quote paths while touching this code).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
